svn commit: r346767 - stable/11/sys/net
Alexander Motin
mav at FreeBSD.org
Fri Apr 26 21:21:56 UTC 2019
Author: mav
Date: Fri Apr 26 21:21:55 2019
New Revision: 346767
URL: https://svnweb.freebsd.org/changeset/base/346767
Log:
MFC r344782: bridge: Fix spurious warnings about capabilities
Mask off the bits we don't care about when checking that capabilities
of the member interfaces have been disabled as intended.
Modified:
stable/11/sys/net/if_bridge.c
Directory Properties:
stable/11/ (props changed)
Modified: stable/11/sys/net/if_bridge.c
==============================================================================
--- stable/11/sys/net/if_bridge.c Fri Apr 26 21:19:06 2019 (r346766)
+++ stable/11/sys/net/if_bridge.c Fri Apr 26 21:21:55 2019 (r346767)
@@ -931,7 +931,7 @@ bridge_set_ifcap(struct bridge_softc *sc, struct bridg
{
struct ifnet *ifp = bif->bif_ifp;
struct ifreq ifr;
- int error;
+ int error, mask, stuck;
BRIDGE_UNLOCK_ASSERT(sc);
@@ -944,10 +944,12 @@ bridge_set_ifcap(struct bridge_softc *sc, struct bridg
if_printf(sc->sc_ifp,
"error setting capabilities on %s: %d\n",
ifp->if_xname, error);
- if ((ifp->if_capenable & ~set) != 0)
+ mask = BRIDGE_IFCAPS_MASK | BRIDGE_IFCAPS_STRIP;
+ stuck = ifp->if_capenable & mask & ~set;
+ if (stuck != 0)
if_printf(sc->sc_ifp,
"can't disable some capabilities on %s: 0x%x\n",
- ifp->if_xname, ifp->if_capenable & ~set);
+ ifp->if_xname, stuck);
}
}
More information about the svn-src-all
mailing list