svn commit: r339523 - in head/sys: conf dev/amdgpio modules modules/amdgpio

[Nathan Whitehorn]

On 10/21/18 1:12 PM, Oleksandr Tymoshenko wrote:
> Nathan Whitehorn (nwhitehorn at freebsd.org) wrote:
>>
>> On 10/20/18 9:52 PM, Oleksandr Tymoshenko wrote:
>>> Author: gonzo
>>> Date: Sun Oct 21 04:52:37 2018
>>> New Revision: 339523
>>> URL: https://svnweb.freebsd.org/changeset/base/339523
>>>
>>> Log:
>>>   Add amdgpio, driver for GPIO controller on AMD-based x86_64 platforms
>>>   
>>>   Submitted by:	Rajesh Kumar <rajbsd at gmail.com>
>>>   Differential Revision:	https://reviews.freebsd.org/D16865
>>>
>> [...]
>>> Modified: head/sys/modules/Makefile
>>> ==============================================================================
>>> --- head/sys/modules/Makefile	Sun Oct 21 02:39:13 2018	(r339522)
>>> +++ head/sys/modules/Makefile	Sun Oct 21 04:52:37 2018	(r339523)
>>> @@ -34,6 +34,7 @@ SUBDIR=	\
>>>  	ale \
>>>  	alq \
>>>  	${_amd_ecc_inject} \
>>> +	${_amdgpio} \
>>>  	${_amdsbwd} \
>>>  	${_amdsmn} \
>>>  	${_amdtemp} \
>>> @@ -717,6 +718,7 @@ _x86bios=	x86bios
>>>  .endif
>>>  
>>>  .if ${MACHINE_CPUARCH} == "amd64"
>>> +_amdgpio=	amdgpio
>>>  _ccp=		ccp
>>>  _efirt=		efirt
>>>  _iavf=		iavf
>>>
>> Does this not work on 64-bit AMD processors running i386 kernels?
> I see no reason why it wouldn't. Probably just haven't been tested.
>

It might be nice if we just added it to all architectures where it
conceivably applies. Essentially all of our code is more portable than
the platforms on which it is tested, so there doesn't seem to be a good
reason to limit such things.
-Nathan