svn commit: r330925 - in head/sys: conf powerpc/powernv
Ian Lepore
ian at freebsd.org
Wed Mar 14 14:21:25 UTC 2018
On Wed, 2018-03-14 at 09:20 +0000, Wojciech Macek wrote:
> Author: wma
> Date: Wed Mar 14 09:20:03 2018
> New Revision: 330925
> URL: https://svnweb.freebsd.org/changeset/base/330925
>
> Log:
> PowerNV: Fix I2C to compile if FDT is disabled
>
> Submitted by: Wojciech Macek <wma at semihalf.com>
> Obtained from: Semihalf
> Sponsored by: IBM, QCM Technologies
>
This seems to be a nonsensical commit. What's the point of compiling
in a driver which is hard-coded to return failure from the probe and
attach routines? The pre-change code seemed more correct: the driver
can only possibly work if FDT/OFW data is available, so only compile it
in when that option is in effect.
-- Ian
More information about the svn-src-all
mailing list