svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa

[John Baldwin]

On Wednesday, January 10, 2018 10:20:17 AM Warner Losh wrote:
> On Wed, Jan 10, 2018 at 10:14 AM, Alexey Dokuchaev <danfe at freebsd.org>
> wrote:
> 
> > On Wed, Jan 10, 2018 at 10:01:41AM -0700, Warner Losh wrote:
> > > On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev <danfe at freebsd.org>
> > wrote:
> > > > On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote:
> > > > > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote:
> > > > > > > New Revision: 327767
> > > > > > > URL: https://svnweb.freebsd.org/changeset/base/327767
> > > > > > >
> > > > > > > Log:
> > > > > > >   Retire pmtimer driver. Move time fixing into apm driver. Move
> > > > > > >   Iwasaki-san's copyright over. Remove FIXME code that couldn't
> > > > possibly
> > > > > > >   work. Call tc_settime() with our estimate of the delta we've
> > been
> > > > > > >   alseep (the one we print) to adjust the time. Not sure what to
> > do
> > > > > > >   about callouts, so keep the small #ifdef in place there.
> > > > > > >
> > > > > > >   Differential Revision: https://reviews.freebsd.org/D13823
> > > > > >
> > > > > > RELNOTES: ?
> > > > > > Reason I ask is this effects custom kernel config file(s)
> > > > >
> > > > > Don't know. We don't normally document every kernel config file
> > changes
> > > > > that's required.
> > > >
> > > > Well, `pmtimer' is a bit special.  It is required in the kernel config
> > in
> > > > order to preserve time counting during suspend (not sure about amd64,
> > but
> > > > at least on i386, "device pmtimer" is required to be in kernel config
> > for
> > > > timekeeping while sleeping).
> > >
> > > It's only required for APM. ACPI it's a nop.
> > >
> > > And it didn't (until I believe that I fixed it) even adjust the time for
> > > APM. On APM it just prints how long the sleep was.
> >
> > Not sure of now, but at least back in 2013 pmtimer was required on my i386
> > ACPI-ish laptop (it is still required now, but I just don't run -CURRENT):
> >
> >   https://lists.freebsd.org/pipermail/svn-src-all/2013-May/069020.html
> 
> 
> It's been a nop in ACPI only on -current. Prior to making it a nop on
> current ACPI set the time, it was a nop for amd64.

Then it probably does warrant a relnotes entry if the effect going from
11 to 12 is that pmtimer has become non-optional / standard, so the
kernel config option is obsolete.

-- 
John Baldwin