svn commit: r329770 - vendor-sys/illumos/dist/uts/common/fs/zfs/lua

[Toomas Soome]

> On 22 Feb 2018, at 05:03, Alexander Motin <mav at FreeBSD.org> wrote:
> 
> On 21.02.2018 20:04, Rodney W. Grimes wrote:
>> [ Charset UTF-8 unsupported, converting... ]
>>> Author: mav
>>> Date: Thu Feb 22 00:46:24 2018
>>> New Revision: 329770
>>> URL: https://svnweb.freebsd.org/changeset/base/329770
>>> 
>>> Log:
>>>  9035 zfs: this statement may fall through
>>> 
>>>  illumos/illumos-gate at 46ac8fdfc5a1f9d8240c79a6ae5b2889cbe83553
>>> 
>>>  Reviewed by: Yuri Pankov <yuripv at yuripv.net>
>>>  Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
>>>  Reviewed by: Matthew Ahrens <mahrens at delphix.com>
>>>  Approved by: Dan McDonald <danmcd at joyent.com>
>>>  Author: Toomas Soome <tsoome at me.com>
>>> 
>>> Modified:
>>>  vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c
>>>  vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c
>>>  vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c
>>>  vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c
>>> 
>>> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c
>>> ==============================================================================
>>> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c	Thu Feb 22 00:42:12 2018	(r329769)
>>> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c	Thu Feb 22 00:46:24 2018	(r329770)
>>> @@ -677,7 +677,7 @@ static void freeobj (lua_State *L, GCObject *o) {
>>>     case LUA_TUSERDATA: luaM_freemem(L, o, sizeudata(gco2u(o))); break;
>>>     case LUA_TSHRSTR:
>>>       G(L)->strt.nuse--;
>>> -      /* go through */
>>> +      /* FALLTHROUGH */
>>>     case LUA_TLNGSTR: {
>>>       luaM_freemem(L, o, sizestring(gco2ts(o)));
>>>       break;
>>> 
>>> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c
>>> ==============================================================================
>>> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c	Thu Feb 22 00:42:12 2018	(r329769)
>>> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c	Thu Feb 22 00:46:24 2018	(r329770)
>>> @@ -475,6 +475,7 @@ static int llex (LexState *ls, SemInfo *seminfo) {
>>>         else if (!lisdigit(ls->current)) return '.';
>>>         /* else go through */
>>          ^^^^^^^^^^^^^^^^^^^^^^^   Wasnt this already marked, perhaps in the
>> wrong place with the wrong string?
> As I understand GCC 7 parses comments like that to decide whether
> generate warnings or not, but this informal text is out of his
> understanding.
> 
> 

Exactly. Also in some cases it is desirable to have more text than just FALLTHROUGH, And in some cases we may just have missed the original comment which should be removed:)

rgds,
toomas