svn commit: r342283 - in head: release/amd64 release/arm64 release/i386 release/tools share/man/man8 tools/boot tools/tools/nanobsd/embedded usr.sbin/bsdinstall/partedit usr.sbin/bsdinstall/scripts

[Ian Lepore]

On Thu, 2018-12-20 at 14:49 -0500, Shawn Webb wrote:
> On Thu, Dec 20, 2018 at 07:39:37PM +0000, Rebecca Cran wrote:
> > 
> > Author: bcran
> > Date: Thu Dec 20 19:39:37 2018
> > New Revision: 342283
> > URL: https://svnweb.freebsd.org/changeset/base/342283
> > 
> > Log:
> >   Rework UEFI ESP generation
> >   
> >   Currently, the installer uses pre-created 800KB FAT12 filesystems
> > that
> >   it dd's onto the ESP partition.
> >   This changeset improves that by having the installer generate a
> > FAT32
> >   filesystem directly onto the ESP using newfs_msdos and then
> > copying
> >   loader.efi into /EFI/freebsd.
> >   For live installs it then runs efibootmgr to add a FreeBSD boot
> > entry
> >   in the BIOS.
> >   
> >   Sponsored by:	Netflix
> >   Differential Revision:	https://reviews.freebsd.org/D17947
> > 
> > Modified:
> >   head/release/amd64/make-memstick.sh
> >   head/release/amd64/mkisoimages.sh
> >   head/release/arm64/make-memstick.sh
> >   head/release/i386/make-memstick.sh
> >   head/release/tools/vmimage.subr
> >   head/share/man/man8/uefi.8
> >   head/tools/boot/install-boot.sh
> >   head/tools/boot/rootgen.sh
> >   head/tools/tools/nanobsd/embedded/common
> >   head/usr.sbin/bsdinstall/partedit/gpart_ops.c
> >   head/usr.sbin/bsdinstall/partedit/partedit_arm64.c
> >   head/usr.sbin/bsdinstall/partedit/partedit_x86.c
> >   head/usr.sbin/bsdinstall/scripts/bootconfig
> >   head/usr.sbin/bsdinstall/scripts/zfsboot
> > 
> > Modified: head/release/amd64/make-memstick.sh
> > ===================================================================
> > ===========
> > --- head/release/amd64/make-memstick.sh	Thu Dec 20 19:27:46
> > 2018	(r342282)
> > +++ head/release/amd64/make-memstick.sh	Thu Dec 20 19:39:37
> > 2018	(r342283)
> > @@ -12,6 +12,9 @@
> >  
> >  set -e
> >  
> > +scriptdir=$(dirname $(realpath $0))
> > +. ${scriptdir}/../../tools/boot/install-boot.sh
> > +
> >  PATH=/bin:/usr/bin:/sbin:/usr/sbin
> >  export PATH
> >  
> > @@ -36,11 +39,16 @@ makefs -B little -o label=FreeBSD_Install -o
> > version=2
> >  rm ${1}/etc/fstab
> >  rm ${1}/etc/rc.conf.local
> >  
> > +# Make an ESP in a file.
> > +espfilename=$(mktemp /tmp/efiboot.XXXXXX)
> > +make_esp_file ${espfilename} ${fat32min} ${1}/boot/loader.efi
> Hey Rebecca,
> 
> Are there any other bits of the build process that touch files
> outside
> of ${MAKEOBJDIRPREFIX}?

Clang puts its temp files in whatever directory TMPDIR is set to
(typically /tmp).

-- Ian