svn commit: r342211 - head/sys/net80211
Andriy Voskoboinyk
avos at FreeBSD.org
Wed Dec 19 03:08:11 UTC 2018
Author: avos
Date: Wed Dec 19 03:08:10 2018
New Revision: 342211
URL: https://svnweb.freebsd.org/changeset/base/342211
Log:
net80211: fix out-of-bounds read in ieee80211_amrr(9).
ieee80211_alloc_node() does not initialize rateset tables; that's not
expected by rate control modules and will result in array access at
index -1 - where ni_essid[] array is located (zeroed at allocation, so
there are no user-visible consequences).
Just delay rate control initialization to the moment, when rateset
tables are initiaziled; nothing will use rates here anyway.
MFC after: 4 days
Modified:
head/sys/net80211/ieee80211_node.c
Modified: head/sys/net80211/ieee80211_node.c
==============================================================================
--- head/sys/net80211/ieee80211_node.c Wed Dec 19 02:34:31 2018 (r342210)
+++ head/sys/net80211/ieee80211_node.c Wed Dec 19 03:08:10 2018 (r342211)
@@ -1417,8 +1417,6 @@ ieee80211_alloc_node(struct ieee80211_node_table *nt,
IEEE80211_NOTE(vap, IEEE80211_MSG_INACT, ni,
"%s: inact_reload %u", __func__, ni->ni_inact_reload);
- ieee80211_ratectl_node_init(ni);
-
return ni;
}
More information about the svn-src-all
mailing list