svn commit: r342185 - head/sys/dev/iwi

Andriy Voskoboinyk avos at FreeBSD.org
Tue Dec 18 05:08:57 UTC 2018


Author: avos
Date: Tue Dec 18 05:08:56 2018
New Revision: 342185
URL: https://svnweb.freebsd.org/changeset/base/342185

Log:
  iwi(4): do not leak node reference when IWI_FLAG_ASSOCIATED flag is set.
  
  MFC after:	6 days

Modified:
  head/sys/dev/iwi/if_iwi.c

Modified: head/sys/dev/iwi/if_iwi.c
==============================================================================
--- head/sys/dev/iwi/if_iwi.c	Tue Dec 18 03:00:12 2018	(r342184)
+++ head/sys/dev/iwi/if_iwi.c	Tue Dec 18 05:08:56 2018	(r342185)
@@ -2833,12 +2833,12 @@ iwi_auth_and_assoc(struct iwi_softc *sc, struct ieee80
 
 	IWI_LOCK_ASSERT(sc);
 
-	ni = ieee80211_ref_node(vap->iv_bss);
-
 	if (sc->flags & IWI_FLAG_ASSOCIATED) {
 		DPRINTF(("Already associated\n"));
 		return (-1);
 	}
+
+	ni = ieee80211_ref_node(vap->iv_bss);
 
 	IWI_STATE_BEGIN(sc, IWI_FW_ASSOCIATING);
 	error = 0;


More information about the svn-src-all mailing list