svn commit: r341973 - stable/12/sys/dev/mlx5/mlx5_en

[Hans Petter Selasky]

Author: hselasky
Date: Wed Dec 12 13:02:00 2018
New Revision: 341973
URL: https://svnweb.freebsd.org/changeset/base/341973

Log:
  MFC r341580:
  mlx5en: Don't set rate on SQs when the SQ is already stopped.
  
  This can happen when connections are short lived and leads to
  a firmware error printout in dmesg, syndrome 0x51cfb0, because
  the SQ is in the wrong state.
  
  Sponsored by:   Mellanox Technologies

Modified:
  stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_rl.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_rl.c
==============================================================================
--- stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_rl.c	Wed Dec 12 13:00:56 2018	(r341972)
+++ stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_rl.c	Wed Dec 12 13:02:00 2018	(r341973)
@@ -458,9 +458,9 @@ mlx5e_rlw_channel_set_rate_locked(struct mlx5e_rl_work
 		    howmany(rate, 1000), burst);
 	}
 
-	/* set new rate */
+	/* set new rate, if SQ is not stopped */
 	sq = channel->sq;
-	if (sq != NULL) {
+	if (sq != NULL && sq->stopped == 0) {
 		error = mlx5e_rl_modify_sq(sq, index);
 		if (error != 0)
 			atomic_add_64(&rlw->priv->rl.stats.tx_modify_rate_failure, 1ULL);