svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2...

[Gordon Tetlow]

On Fri, Aug 17, 2018 at 12:23:51AM +0000, Conrad Meyer wrote:
> Author: cem
> Date: Fri Aug 17 00:23:50 2018
> New Revision: 337936
> URL: https://svnweb.freebsd.org/changeset/base/337936
> 
> Log:
>   Bring in libsodium to sys/contrib
>   
>   Bring in https://github.com/jedisct1/libsodium at
>   461ac93b260b91db8ad957f5a576860e3e9c88a1 (August 7, 2018), unmodified.
>   
>   libsodium is derived from Daniel J. Bernstein et al.'s 2011 NaCl
>   ("Networking and Cryptography Library," pronounced "salt") software library.
>   At the risk of oversimplifying, libsodium primarily exists to make it easier
>   to use NaCl.  NaCl and libsodium provide high quality implementations of a
>   number of useful cryptographic concepts (as well as the underlying
>   primitics) seeing some adoption in newer network protocols.
>   
>   I considered but dismissed cleaning up the directory hierarchy and
>   discarding artifacts of other build systems in favor of remaining close to
>   upstream (and easing future updates).
>   
>   Nothing is integrated into the build system yet, so in that sense, no
>   functional change.

Hi! so@ here. Please don't integrate an additional crypto library
without consultation from secteam. Bringing in a different crypto
implementation has very serious downstream costs. Additionally, I don't
see any discussion on current, hackers, arch, or security with a plan
for why this is coming into the tree. That said, I've been on vacation
the last two weeks, so if I missed something, please feel free to point
it out to me.

Thanks,
Gordon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20180817/3476be66/attachment.sig>