svn commit: r320582 - stable/10/lib/libc/rpc

[Xin LI]

Author: delphij
Date: Mon Jul  3 02:14:42 2017
New Revision: 320582
URL: https://svnweb.freebsd.org/changeset/base/320582

Log:
  MFC r320494: Fix double free by reverting r300385 and r300624 which was
  false positive reported by cppcheck.

Modified:
  stable/10/lib/libc/rpc/getnetconfig.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libc/rpc/getnetconfig.c
==============================================================================
--- stable/10/lib/libc/rpc/getnetconfig.c	Mon Jul  3 02:11:14 2017	(r320581)
+++ stable/10/lib/libc/rpc/getnetconfig.c	Mon Jul  3 02:14:42 2017	(r320582)
@@ -692,7 +692,7 @@ static struct netconfig *
 dup_ncp(struct netconfig *ncp)
 {
     struct netconfig	*p;
-    char	*tmp, *tmp2;
+    char	*tmp;
     u_int	i;
 
     if ((tmp=malloc(MAXNETCONFIGLINE)) == NULL)
@@ -701,7 +701,6 @@ dup_ncp(struct netconfig *ncp)
 	free(tmp);
 	return(NULL);
     }
-    tmp2 = tmp;
     /*
      * First we dup all the data from matched netconfig buffer.  Then we
      * adjust some of the member pointer to a pre-allocated buffer where
@@ -723,7 +722,6 @@ dup_ncp(struct netconfig *ncp)
     if (p->nc_lookups == NULL) {
 	free(p->nc_netid);
 	free(p);
-	free(tmp2);
 	return(NULL);
     }
     for (i=0; i < p->nc_nlookups; i++) {