svn commit: r312995 - head/sys/dev/mpr

Alan Somers asomers at FreeBSD.org
Mon Jan 30 19:49:09 UTC 2017


Author: asomers
Date: Mon Jan 30 19:49:08 2017
New Revision: 312995
URL: https://svnweb.freebsd.org/changeset/base/312995

Log:
  Initialize a stack variable in mprsas_get_sas_address_for_sata_disk
  
  Thought it's difficult to reproduce, I think this variable was responsible
  for a use-after-free panic when a SATA disk timed out responding to a SATA
  identify command during boot.
  
  Submitted by:	slm
  Reviewed by:	slm
  MFC after:	4 weeks
  Sponsored by:	Spectra Logic Corp
  Differential Revision:	https://reviews.freebsd.org/D9364

Modified:
  head/sys/dev/mpr/mpr_sas_lsi.c

Modified: head/sys/dev/mpr/mpr_sas_lsi.c
==============================================================================
--- head/sys/dev/mpr/mpr_sas_lsi.c	Mon Jan 30 18:51:43 2017	(r312994)
+++ head/sys/dev/mpr/mpr_sas_lsi.c	Mon Jan 30 19:49:08 2017	(r312995)
@@ -911,6 +911,7 @@ mprsas_get_sas_address_for_sata_disk(str
 	u8 sas_status;
 
 	memset(&ata_identify, 0, sizeof(ata_identify));
+	memset(&mpi_reply, 0, sizeof(mpi_reply));
 	try_count = 0;
 	do {
 		rc = mprsas_get_sata_identify(sc, handle, &mpi_reply,


More information about the svn-src-all mailing list