svn commit: r314322 - head/lib/librss

[Cy Schubert]

In message <201702270010.v1R0A1wm074123 at repo.freebsd.org>, "Pedro F. 
Giffuni" w
rites:
> Author: pfg
> Date: Mon Feb 27 00:10:00 2017
> New Revision: 314322
> URL: https://svnweb.freebsd.org/changeset/base/314322
> 
> Log:
>   librss: simplify some NULL checks.
>   
>   MFC after:	1 week
> 
> Modified:
>   head/lib/librss/librss.c
> 
> Modified: head/lib/librss/librss.c
> =============================================================================
> =
> --- head/lib/librss/librss.c	Sun Feb 26 22:17:06 2017	(r314321)
> +++ head/lib/librss/librss.c	Mon Feb 27 00:10:00 2017	(r314322)
> @@ -244,10 +244,10 @@ rss_config_get(void)
>  	return (rc);
>  
>  error:
> -	if ((rc != NULL) && rc->rss_bucket_map)
> +	if (rc != NULL) {
>  		free(rc->rss_bucket_map);

What happens if rc is not NULL and rc->rss_bucket_map is NULL?

> -	if (rc != NULL)
>  		free(rc);
> +	}
>  	return (NULL);
>  }
>  
> 
> 


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.