svn commit: r313401 - head/sys/netinet
Gleb Smirnoff
glebius at FreeBSD.org
Fri Feb 10 20:10:11 UTC 2017
On Tue, Feb 07, 2017 at 06:57:57PM +0000, Eric van Gyzen wrote:
E> Author: vangyzen
E> Date: Tue Feb 7 18:57:57 2017
E> New Revision: 313401
E> URL: https://svnweb.freebsd.org/changeset/base/313401
E>
E> Log:
E> Fix garbage IP addresses in UDP log_in_vain messages
E>
E> If multiple threads emit a UDP log_in_vain message concurrently,
E> the IP addresses could be garbage due to concurrent usage of a
E> single string buffer inside inet_ntoa(). Use inet_ntoa_r() with
E> two stack buffers instead.
E>
E> Reported by: Mark Martinec <Mark.Martinec+freebsd at ijs.si>
E> MFC after: 3 days
E> Relnotes: yes
E> Sponsored by: Dell EMC
Thanks. I think inet_ntoa() and anything that uses static buffer
should just be removed from libkern.
--
Totus tuus, Glebius.
More information about the svn-src-all
mailing list