svn commit: r313216 - stable/10/tests/sys/mac/bsdextended

[Ngie Cooper]

Author: ngie
Date: Sat Feb  4 16:15:26 2017
New Revision: 313216
URL: https://svnweb.freebsd.org/changeset/base/313216

Log:
  MFC r312120:
  
  Fix warnings
  
  - Staticize test_num
  - Promote i to size_t to deal with -Wsign-compare issues
  
  Tested with:	clang, gcc, gcc49

Modified:
  stable/10/tests/sys/mac/bsdextended/ugidfw_test.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/tests/sys/mac/bsdextended/ugidfw_test.c
==============================================================================
--- stable/10/tests/sys/mac/bsdextended/ugidfw_test.c	Sat Feb  4 16:09:07 2017	(r313215)
+++ stable/10/tests/sys/mac/bsdextended/ugidfw_test.c	Sat Feb  4 16:15:26 2017	(r313216)
@@ -71,7 +71,7 @@ static const char *test_groups[] = {
 	"bin",
 };
 
-int test_num;
+static int test_num;
 
 /*
  * List of test strings that must go in (and come out) of libugidfw intact.
@@ -149,7 +149,8 @@ test_libugidfw_strings(void)
 	struct mac_bsdextended_rule rule;
 	char errorstr[256];
 	char rulestr[256];
-	int error, i;
+	size_t i;
+	int error;
 
 	for (i = 0; i < nitems(test_users); i++, test_num++) {
 		if (getpwnam(test_users[i]) == NULL)
@@ -171,7 +172,7 @@ test_libugidfw_strings(void)
 		error = bsde_parse_rule_string(test_strings[i], &rule,
 		    sizeof(errorstr), errorstr);
 		if (error == -1)
-			printf("not ok %d # bsde_parse_rule_string: '%s' (%d) "
+			printf("not ok %d # bsde_parse_rule_string: '%s' (%zu) "
 			    "failed: %s\n", test_num, test_strings[i], i, errorstr);
 		else
 			printf("ok %d\n", test_num);