svn commit: r321920 - head/sys/sys

[Hans Petter Selasky]

On 08/02/17 14:36, Hans Petter Selasky wrote:
> On 08/02/17 12:14, Konstantin Belousov wrote:
>> +#define    major(x)    ((int)((dev_t)(x) >> 32))    /* major number */
>> +#define    minor(x)    ((int)((x) & 0xffffffff))    /* minor number */
>> +#define    makedev(x, y)    (((dev_t)(x) << 32) | (y))    /* create 
>> dev_t */
> 
> One more comment on this issue:
> 
> I think makedev(x, y) should be declared like this, to avoid issues when 
> "y" is negative:
> 
> #define    makedev(x, y)    (((dev_t)(x) << 32) | (unsigned int)(y))    
> /* create dev_t */
> 
> ???
> 
> --HPS
> 
> 

And you'll probably want a final wrapping dev_t cast aswell. 128-bit 
numbers are not yet there.

#define	makedev(x, y)    ((dev_t)(((dev_t)(x) << 32) | (unsigned 
int)(y)))
 > /* create dev_t */

--HPS