svn commit: r317290 - head/tools/regression/geom_gpt
Rodney W. Grimes
freebsd at pdx.rh.CN85.dnsmgr.net
Sat Apr 22 20:06:43 UTC 2017
> Author: ngie
> Date: Sat Apr 22 20:00:52 2017
> New Revision: 317290
> URL: https://svnweb.freebsd.org/changeset/base/317290
>
> Log:
> Fix -Wimplicit-function-declaration compilation warning by moving libgeom.h
> #include below the stdio.h #include.
>
> gctl_dump(3) needs stdio.h, per reasoning noted in r317289.
>
> MFC after: 5 weeks
> PR: 218809
> Submitted by: Chang-Hsien Tsai <luke.tw at gmail.com>
> Sponsored by: Dell EMC Isilon
>
> Modified:
> head/tools/regression/geom_gpt/test.c
>
> Modified: head/tools/regression/geom_gpt/test.c
> ==============================================================================
> --- head/tools/regression/geom_gpt/test.c Sat Apr 22 19:32:23 2017 (r317289)
> +++ head/tools/regression/geom_gpt/test.c Sat Apr 22 20:00:52 2017 (r317290)
> @@ -29,12 +29,12 @@ __FBSDID("$FreeBSD$");
>
> #include <sys/param.h>
> #include <errno.h>
> -#include <libgeom.h>
> #include <limits.h>
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> #include <unistd.h>
> +#include <libgeom.h>
#include <libgeom.h> /* This is not in alphabetic order per r317289 */
>
> struct retval {
> struct retval *retval;
Might it be a good idea to mark this in the test.c file as to why
these are not sorted in order to prevent regressions of this in
the future?
--
Rod Grimes rgrimes at freebsd.org
More information about the svn-src-all
mailing list