svn commit: r316993 - head/contrib/ipfilter/lib

[Conrad Meyer]

On Sat, Apr 15, 2017 at 6:13 PM, Cy Schubert <cy at freebsd.org> wrote:
> Author: cy
> Date: Sun Apr 16 01:13:47 2017
> New Revision: 316993
> URL: https://svnweb.freebsd.org/changeset/base/316993
>
> Log:
>   Fix CID 1372601, possible NULL pointer dereference should
>   reallocarray() fail.
>
>   Reported by:  Coverity CID 1372601
>   MFC after:    1 week
>
> Modified:
>   head/contrib/ipfilter/lib/parsefields.c
>
> Modified: head/contrib/ipfilter/lib/parsefields.c
> ==============================================================================
> --- head/contrib/ipfilter/lib/parsefields.c     Sat Apr 15 23:35:57 2017        (r316992)
> +++ head/contrib/ipfilter/lib/parsefields.c     Sun Apr 16 01:13:47 2017        (r316993)
> @@ -32,6 +32,10 @@ wordtab_t *parsefields(table, arg)
>                         fields = malloc(2 * sizeof(*fields));
>                 } else {
>                         fields = reallocarray(fields, num + 1, sizeof(*fields));
> +                       if (fields == NULL) {
> +                               perror("memory allocation error at __LINE__ in __FUNCTIOIN__ in __FILE__");

Hey Cy,

Does this actually work?  I was under the impression it wouldn't work.
Instead, maybe warnx("... error at %d in %s in %s", __LINE__,
__func__, __FILE__)?

Best,
Conrad