svn commit: r305640 - stable/11/lib/libusb
Hans Petter Selasky
hselasky at FreeBSD.org
Fri Sep 9 06:25:41 UTC 2016
Author: hselasky
Date: Fri Sep 9 06:25:40 2016
New Revision: 305640
URL: https://svnweb.freebsd.org/changeset/base/305640
Log:
MFC r305284:
Fix array size issue when using the pre-scaling feature for
ISOCHRONOUS USB transfers. Make sure enough length and buffer pointers
are allocated when setting up the libusb transfer structure to support
the maximum number of frames the kernel can handle.
Modified:
stable/11/lib/libusb/libusb20.c
Directory Properties:
stable/11/ (props changed)
Modified: stable/11/lib/libusb/libusb20.c
==============================================================================
--- stable/11/lib/libusb/libusb20.c Fri Sep 9 04:54:41 2016 (r305639)
+++ stable/11/lib/libusb/libusb20.c Fri Sep 9 06:25:40 2016 (r305640)
@@ -176,6 +176,12 @@ libusb20_tr_open_stream(struct libusb20_
return (LIBUSB20_ERROR_BUSY);
if (MaxFrameCount & LIBUSB20_MAX_FRAME_PRE_SCALE) {
MaxFrameCount &= ~LIBUSB20_MAX_FRAME_PRE_SCALE;
+ /*
+ * The kernel can setup 8 times more frames when
+ * pre-scaling ISOCHRONOUS transfers. Make sure the
+ * length and pointer buffers are big enough:
+ */
+ MaxFrameCount *= 8;
pre_scale = 1;
} else {
pre_scale = 0;
@@ -200,8 +206,13 @@ libusb20_tr_open_stream(struct libusb20_
}
memset(xfer->ppBuffer, 0, size);
- error = xfer->pdev->methods->tr_open(xfer, MaxBufSize,
- MaxFrameCount, ep_no, stream_id, pre_scale);
+ if (pre_scale) {
+ error = xfer->pdev->methods->tr_open(xfer, MaxBufSize,
+ MaxFrameCount / 8, ep_no, stream_id, 1);
+ } else {
+ error = xfer->pdev->methods->tr_open(xfer, MaxBufSize,
+ MaxFrameCount, ep_no, stream_id, 0);
+ }
if (error) {
free(xfer->ppBuffer);
More information about the svn-src-all
mailing list