svn commit: r308696 - in head: share/man/man4 sys/boot/forth sys/conf sys/dev/bnxt sys/modules sys/modules/bnxt

[Conrad Meyer]

Hi Stephen,

Coverity reports a missing 'break;' (or explicit /* FALLTHROUGH */) in
if_bnxt.c:1915.  (The HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASEKR cases
flow into the HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASELR case.)  CID is
1366223.

If the fall-through is intentional, please add the comment.  If it
isn't, I guess it needs a break statement.

Thanks,
Conrad

On Tue, Nov 15, 2016 at 12:35 PM, Stephen Hurd <shurd at freebsd.org> wrote:
> Author: shurd (ports committer)
> Date: Tue Nov 15 20:35:29 2016
> New Revision: 308696
> URL: https://svnweb.freebsd.org/changeset/base/308696
>
> Log:
>   New driver for Broadcom NetXtreme-C and NetXtreme-E devices.
>
>   This driver uses the iflib framework supporting Broadcom
>   25/50Gbps devices.
>
>   Reviewed by:  gallatin, wblock
>   Approved by:  davidch
>   MFC after:    2 weeks
>   Relnotes:     yes
>   Sponsored by: Broadcom Limited
>   Differential Revision:        https://reviews.freebsd.org/D7551
>
> Added:
>   head/share/man/man4/bnxt.4   (contents, props changed)
>   head/sys/dev/bnxt/
>   head/sys/dev/bnxt/bnxt.h   (contents, props changed)
>   head/sys/dev/bnxt/bnxt_hwrm.c   (contents, props changed)
>   head/sys/dev/bnxt/bnxt_hwrm.h   (contents, props changed)
>   head/sys/dev/bnxt/bnxt_ioctl.h   (contents, props changed)
>   head/sys/dev/bnxt/bnxt_sysctl.c   (contents, props changed)
>   head/sys/dev/bnxt/bnxt_sysctl.h   (contents, props changed)
>   head/sys/dev/bnxt/bnxt_txrx.c   (contents, props changed)
>   head/sys/dev/bnxt/convert_hsi.pl   (contents, props changed)
>   head/sys/dev/bnxt/hsi_struct_def.h   (contents, props changed)
>   head/sys/dev/bnxt/if_bnxt.c   (contents, props changed)
>   head/sys/modules/bnxt/
>   head/sys/modules/bnxt/Makefile   (contents, props changed)
> Modified:
>   head/share/man/man4/Makefile
>   head/sys/boot/forth/loader.conf
>   head/sys/conf/NOTES
>   head/sys/conf/files
>   head/sys/modules/Makefile
>
> ...
>
> *** DIFF OUTPUT TRUNCATED AT 1000 LINES ***