svn commit: r296320 - in head/sys: kern sys

[Hans Petter Selasky]

On 03/03/16 12:58, Konstantin Belousov wrote:
>> >
>> >Yes, your change is compatible if you compile the code, but not binary
>> >compatible. See the following macros, and how they use _callout_stop_safe():
> My change is binary compatible.
>
>> >
>> >#define callout_stop(c)         _callout_stop_safe(c, 0, NULL)
>> >#define callout_async_drain(c, d)                                       \
>> >      _callout_stop_safe(c, 0, d)
>> >
>> >Because callout_stop(c) is a macro, you've now change the API for
>> >callout_stop() aswell. This is what I think will break binary
>> >compatibility in 10.x.
> How my commit changes anything for either callout_stop(), or for
> callout_async_drain(), or for callout_drain() ?
>

Hi,

It looked like you added another argument to _callout_stop_safe(). After 
a closer look I see the patch is binary compatible.

--HPS