svn commit: r290220 - head/share/mk

[Bryan Drewery]

On 10/30/2015 8:30 PM, Bryan Drewery wrote:
> 
> 
>> On Oct 30, 2015, at 19:18, NGie Cooper <yaneurabeya at gmail.com> wrote:
>>
>>> On Fri, Oct 30, 2015 at 7:07 PM, Bryan Drewery <bdrewery at freebsd.org> wrote:
>>> Author: bdrewery
>>> Date: Sat Oct 31 02:07:30 2015
>>> New Revision: 290220
>>> URL: https://svnweb.freebsd.org/changeset/base/290220
>>>
>>> Log:
>>>  Don't hide stderr when checking ${CC} --version.
>>>
>>>  This can have important debugging information such as 'cc: not found' or
>>>  'ccache: error: Could not find compiler "cc" in PATH'.
>>
>> Won't this spam installworld/distribution a lot?
> 
> Not for me.
> 
> What do you expect from stderr that is non-fatal? The only cases I've
> had so far resulted in the .error triggering later due to not being able
> to determine compiler type.
> 
> Also, install depending on the compiler type is wrong. We need to
> eliminate the cases where it determines SUBDIR or FILES to fix this. I'd
> like to effectively set CC=false during install but can't while those
> checks exist.
> 

Setting CC=false would cause the warnings, but that's a symptom of the
larger problem I mentioned about even using bsd.compiler.mk in install.


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20151030/7b927748/attachment.bin>