svn commit: r289778 - head/share/mk

[Bryan Drewery]

> On Oct 22, 2015, at 17:18, Bryan Drewery <bdrewery at FreeBSD.org> wrote:
> 
> 
> 
>>> On Oct 22, 2015, at 16:59, Ian Lepore <ian at freebsd.org> wrote:
>>> 
>>> On Thu, 2015-10-22 at 23:41 +0000, Bryan Drewery wrote:
>>> Author: bdrewery
>>> Date: Thu Oct 22 23:41:56 2015
>>> New Revision: 289778
>>> URL: https://svnweb.freebsd.org/changeset/base/289778
>>> 
>>> Log:
>>> For SUBDIR_PARALLEL, when doing 'make clean*' or 'make obj' there
>>> is no need to
>>> respect SUBDIR_DEPEND_* or .WAIT.
>>> 
>>> MFC after:    2 weeks
>>> Sponsored by:    EMC / Isilon Storage Division
>> 
>> This doesn't feel so safe.  People override these targets and do who
>> -knows-what with them.  The clean* seems especially risky since it will
>> match targets in end-user makefiles that you don't even know about.

I can also not apply to SUBDIR_TARGETS which is the user-defined targets list. (Misspelled and should be LOCAL_SUBDIR_TARGETS)

>> 
>> -- Ian
> 
> I can limit it to src tree builds if you want.
> 
> I cannot imagine any situation where "clean<something>" depends on another directory going first. 
> 
> Similarly it makes sense to always build subdirs in parallel with 'obj' and I would argue 'clean*' too, regardless of SUBDIR_PARALLEL. I only just realized that. Yes there are mkdir -p and rm -f races, but we have not added any dependencies because of these as is.