svn commit: r289728 - head

[Bryan Drewery]

On 10/21/2015 6:45 PM, Alexander Kabaev wrote:
> On Thu, 22 Oct 2015 01:32:11 +0000 (UTC)
> Ed Maste <emaste at FreeBSD.org> wrote:
> 
>> Author: emaste
>> Date: Thu Oct 22 01:32:11 2015
>> New Revision: 289728
>> URL: https://svnweb.freebsd.org/changeset/base/289728
>>
>> Log:
>>   Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>>   
>>   NO_CLEAN has been the correct spelling for over a decade.
>>
>> Modified:
>>   head/Makefile.inc1
>>
>> Modified: head/Makefile.inc1
>> ==============================================================================
>> --- head/Makefile.inc1	Thu Oct 22 01:04:31 2015
>> (r289727) +++ head/Makefile.inc1	Thu Oct 22 01:32:11
>> 2015	(r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
>>  .endif	# !empty(SUBDIR_OVERRIDE)
>>  
>>  .if defined(NOCLEAN)
>> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>>  NO_CLEAN=	${NOCLEAN}
>>  .endif
>>  .if defined(NO_CLEANDIR)
> 
> 
> For some definition of 'correct'. It definitely is not for those who
> have -DNOCLEAN wired into their finger memory and above mentioned
> decade did not help with that any.
> 
> I think some of the common spellings were left as is in great NO_<foo>
> revolution for a reason and I see no reason why the sudden itch to
> change that.
> 

I almost argued against this before it went in but I felt I had outspent
my negative credits for the week on gdb->lldb and login(1) and stayed
out of it.

I've always been confused on the "correct" spelling and usually go open
the file to see which is supported. I do see both being suggested often
though and see that at work our build configuration does use -DNOCLEAN
too (not my change). This is something that doesn't seem worth hassling
people over.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20151021/be17c243/attachment.bin>