svn commit: r289410 - head/gnu/usr.bin/binutils/ld
Bryan Drewery
bdrewery at FreeBSD.org
Fri Oct 16 05:54:43 UTC 2015
Author: bdrewery
Date: Fri Oct 16 05:54:41 2015
New Revision: 289410
URL: https://svnweb.freebsd.org/changeset/base/289410
Log:
Avoid warning race with creating 'ldscripts' directory during build.
In r204548 the 'rm -f ldscripts' was added likely due to reading the
conditional as 'else it is a file'. That seems unlikely though and
the more likely case is just that the directory hasn't been created yet.
Because this races with ,ssother scripts, use 'mkdir -p' which is a minimal
modification vs upstream to avoid the warning of 'File exists' if another
script creates it first. This could replace the 'test -d' as well but
then it's more unneeded change to the upstream script.
Sponsored by: EMC / Isilon Storage Division
Modified:
head/gnu/usr.bin/binutils/ld/genscripts.sh
Modified: head/gnu/usr.bin/binutils/ld/genscripts.sh
==============================================================================
--- head/gnu/usr.bin/binutils/ld/genscripts.sh Fri Oct 16 05:13:21 2015 (r289409)
+++ head/gnu/usr.bin/binutils/ld/genscripts.sh Fri Oct 16 05:54:41 2015 (r289410)
@@ -50,8 +50,7 @@ fi
if test -d ldscripts; then
true
else
- rm -f ldscripts
- mkdir ldscripts
+ mkdir -p ldscripts
fi
# Set some flags for the emultempl scripts. USE_LIBPATH will
More information about the svn-src-all
mailing list