svn commit: r279814 - head/sys/arm/conf

[Warner Losh]

> On Mar 9, 2015, at 9:58 AM, Ian Lepore <ian at FreeBSD.org> wrote:
> 
> On Mon, 2015-03-09 at 15:43 +0000, Warner Losh wrote:
>> Author: imp
>> Date: Mon Mar  9 15:43:33 2015
>> New Revision: 279814
>> URL: https://svnweb.freebsd.org/changeset/base/279814
>> 
>> Log:
>>  Add the DTrace modules to the build, rather than only build the dtrace
>>  modules.
>> 
>> Modified:
>>  head/sys/arm/conf/BEAGLEBONE
>> 
>> Modified: head/sys/arm/conf/BEAGLEBONE
>> ==============================================================================
>> --- head/sys/arm/conf/BEAGLEBONE	Mon Mar  9 15:31:33 2015	(r279813)
>> +++ head/sys/arm/conf/BEAGLEBONE	Mon Mar  9 15:43:33 2015	(r279814)
>> @@ -31,7 +31,7 @@ makeoptions	WITHOUT_MODULES="ahc"
>> options 	KDTRACE_HOOKS		# Kernel DTrace hooks
>> options 	DDB_CTF			# all architectures - kernel ELF linker loads CTF data
>> makeoptions	WITH_CTF=1
>> -makeoptions	MODULES_OVERRIDE="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt"
>> +makeoptions	MODULES_EXTRA="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt"
>> 
>> options 	HZ=100
>> options 	SCHED_4BSD		# 4BSD scheduler
>> 
>> 
> 
> Can we not do this, and instead just build all modules?  I'm not sure
> why we eliminate or override modules on some armv6 socs and not on
> others, but I think it's a concept that's past it's sell-by date now.
> If there are a few specific modules that aren't good for arm, we should
> be fixing that in the modules makefiles.

I assumed that this was here to give the folks working on Dtrace a bigger
audience without breaking everybody if they are wrong. The prior change
to the config file introduced MODULES_OVERRIDE, and it should have
used MODULES_EXTRA because that’s what it is doing. I assume that
this line will be eliminated when the sys/modules stuff turns on dtrace
for arm.

> I've got some WIP along these lines for beaglebone that's about ready to
> commit, so I'm asking your opinion, not for you to do all the work.

As for MODULES_OVERRIDE elimination, I’m all for it. I have some
early WiP to filter modules in a smarter way (e.g. never compile USB modules
if there can be no USB, ditto PCI). But that’s still some months away from
coming to fruition. As we talked about on IRC, I’m cool with eliminating the
MODULES_OVERRIDE for all armv6 config files.

Warner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150309/a2a77d64/attachment.sig>