svn commit: r285270 - head/sys/sys

[Zbigniew Bodek]

Hello,

You are absolutely right. Especially semicolons... I must have missed
this somehow.
Thanks. Fixed in r285293.

Best regards
zbb

2015-07-08 21:47 GMT+02:00 John-Mark Gurney <jmg at funkthat.com>:
> Zbigniew Bodek wrote this message on Wed, Jul 08, 2015 at 13:53 +0000:
>> +#if defined(__arm__)
>> +     #define __BUS_DMAMAP_SYNC_DEFAULT               mb();
>> +#elif defined(__aarch64__)
>> +     #define __BUS_DMAMAP_SYNC_DEFAULT               dmb(sy);
>
> These shouldn't have ; after them...
>
>> +#else
>> +     #define __BUS_DMAMAP_SYNC_DEFAULT               {}
>
> The correct spelling of this should probably be:
> do {  } while (0)
>
>> +#endif
>>  #define bus_dmamap_sync(dmat, dmamap, op)                    \
>>       do {                                                    \
>>               if ((dmamap) != NULL)                           \
>>                       _bus_dmamap_sync(dmat, dmamap, op);     \
>> +             else                                            \
>> +                     __BUS_DMAMAP_SYNC_DEFAULT               \
>
> And then this can be properly written w/ a ; at the end...
>
> --
>   John-Mark Gurney                              Voice: +1 415 225 5579
>
>      "All that I will do, has been done, All that I have, has not."