svn commit: r277347 - head/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sun Jan 18 20:53:20 2015
New Revision: 277347
URL: https://svnweb.freebsd.org/changeset/base/277347

Log:
  Add protection code to free memory in case of processing an address which
  is neither IPv4 or IPv6.
  
  Reported by:	Coverity
  CID:		749311
  MFC after:	1 week

Modified:
  head/sys/netinet/sctp_asconf.c

Modified: head/sys/netinet/sctp_asconf.c
==============================================================================
--- head/sys/netinet/sctp_asconf.c	Sun Jan 18 20:47:21 2015	(r277346)
+++ head/sys/netinet/sctp_asconf.c	Sun Jan 18 20:53:20 2015	(r277347)
@@ -3346,6 +3346,11 @@ sctp_asconf_send_nat_state_update(struct
 		TAILQ_INSERT_TAIL(&stcb->asoc.asconf_queue, aa, next);
 		break;
 #endif
+	default:
+		SCTPDBG(SCTP_DEBUG_ASCONF1,
+		    "sctp_asconf_send_nat_state_update: unknown address family\n");
+		SCTP_FREE(aa, SCTP_M_ASC_ADDR);
+		return;
 	}
 	SCTP_MALLOC(aa, struct sctp_asconf_addr *, sizeof(*aa),
 	    SCTP_M_ASC_ADDR);
@@ -3379,6 +3384,11 @@ sctp_asconf_send_nat_state_update(struct
 		TAILQ_INSERT_TAIL(&stcb->asoc.asconf_queue, aa, next);
 		break;
 #endif
+	default:
+		SCTPDBG(SCTP_DEBUG_ASCONF1,
+		    "sctp_asconf_send_nat_state_update: unknown address family\n");
+		SCTP_FREE(aa, SCTP_M_ASC_ADDR);
+		return;
 	}
 	/* Now we must hunt the addresses and add all global addresses */
 	if (stcb->sctp_ep->sctp_flags & SCTP_PCB_FLAGS_BOUNDALL) {