svn commit: r279338 - head/sys/arm/include
John Baldwin
jhb at freebsd.org
Sat Feb 28 12:41:30 UTC 2015
On Saturday, February 28, 2015 12:38:00 PM Bruce Evans wrote:
> On Fri, 27 Feb 2015, Ian Lepore wrote:
> > ::sigh:: As usual, thousands of words, maybe there's actionable info in
> >
> > there, but I sure don't have time to ferret it out.
> >
> > If there's something simple you'd like me to do, please say so. Simply.
>
> Just back out the change. For extra credit, back it out for i386 too.
> For too much work, fix the 17 calls with bogus casts.
Yes. For better or for worse, atomic_*_ptr operate on uintptr_t objects, not
void * objects. Bruce explained this to DES before but DES ignored him. If
you really want to use explicit atomic ops on void * objects, then the
suggestion back then was to add a new 'atomic_*_intptr' or the like and
convert all existing uintptr objects (like all the lock cookies) to use those
and then change atomic_*_ptr to operate on void * objects. However, that's a
fair bit of work.
--
John Baldwin
More information about the svn-src-all
mailing list