svn commit: r278640 - head/sys/netgraph

[Julian Elischer]

On 2/13/15 4:05 PM, Gleb Smirnoff wrote:
>    Hi!
>
> On Thu, Feb 12, 2015 at 10:20:34PM +0000, Gleb Smirnoff wrote:
> T> Author: glebius
> T> Date: Thu Feb 12 22:20:34 2015
> T> New Revision: 278640
> T> URL: https://svnweb.freebsd.org/changeset/base/278640
> T>
> T> Log:
> T>   Revise default limit for maximum of netgraph data items.
> T>   With modern internet speeds the limit can be reached even
> T>   on a single L2TP link.
>
> Actually any ng_item of data type requires an mbuf to be connected
> to it, and thus I suggest to use mbuf limits to drive ng_item limits.
>
> If we got an item leak with mbufs being properly freed, then we've
> got a bug to fix, and any limit won't work in long run time. I never
> evidenced such a bug, but there complaints on hitting limit at
> traffic bursts. As said, with previous 512 item limit I experienced
> that even on a laptop.
>
> Any objections on removing the limit, guys?
maybe derived from it, but not the same number.
maybe change the systctl to define the relationship?

>
> T> Modified:
> T>   head/sys/netgraph/ng_base.c
> T>
> T> Modified: head/sys/netgraph/ng_base.c
> T> ==============================================================================
> T> --- head/sys/netgraph/ng_base.c	Thu Feb 12 21:20:28 2015	(r278639)
> T> +++ head/sys/netgraph/ng_base.c	Thu Feb 12 22:20:34 2015	(r278640)
> T> @@ -2952,7 +2952,7 @@ uma_zone_t			ng_qzone;
> T>  uma_zone_t			ng_qdzone;
> T>  static int			numthreads = 0; /* number of queue threads */
> T>  static int			maxalloc = 4096;/* limit the damage of a leak */
> T> -static int			maxdata = 512;	/* limit the damage of a DoS */
> T> +static int			maxdata = 4096;	/* limit the damage of a DoS */
> T>
> T>  SYSCTL_INT(_net_graph, OID_AUTO, threads, CTLFLAG_RDTUN, &numthreads,
> T>      0, "Number of queue processing threads");
> T>
>