Re: svn commit: r278012 - head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/usdt

[Rui Paulo]

On Jan 31, 2015, at 03:12 PM, Mark Johnston <markj at FreeBSD.org> wrote:

Author: markj
Date: Sat Jan 31 23:12:29 2015
New Revision: 278012
URL: https://svnweb.freebsd.org/changeset/base/278012

Log:
Fix mktemp(1) usage.

MFC after:  1 week

Modified:
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/usdt/tst.corruptenv.ksh

Modified: head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/usdt/tst.corruptenv.ksh
==============================================================================
--- head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/usdt/tst.corruptenv.ksh  Sat Jan 31 23:11:57 2015    (r278011)
+++ head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/usdt/tst.corruptenv.ksh      Sat Jan 31 23:12:29 2015    (r278012)
@@ -48,7 +48,7 @@ fi

dtrace="$1"
startdir="$PWD"
-dir=$(mktemp -td drtiXXXXXX)
+dir=$(mktemp -d -t drtiXXXXXX)
if (( $? != 0 )); then
   print -u2 'Could not create safe temporary directory'
   exit 2
 
I hit this exact same problem in xz-utils when running the test suite.  I think this is a bug in our mktemp and perhaps it's time we move to a version of mktemp that everyone else uses: mktemp.org.