svn commit: r278321 - head/sys/dev/ipmi
John Baldwin
jhb at freebsd.org
Fri Feb 6 17:01:56 UTC 2015
On Friday, February 06, 2015 04:45:11 PM John Baldwin wrote:
> Author: jhb
> Date: Fri Feb 6 16:45:10 2015
> New Revision: 278321
> URL: https://svnweb.freebsd.org/changeset/base/278321
>
> Log:
> Use direct hardware access for internal requests for KCS and SMIC. In
> particular, updates to the watchdog should no longer sleep.
> - Add a new IPMI_IO_LOCK for low-level I/O access. Use this for
> kcs_polled_request() and smic_polled_request().
> - Add a new backend callback "ipmi_driver_request" to handle a driver
> request. The new callback performs the request sychronously for KCS
> and SMIC. SSIF still defers the work to the worker thread since the
> worker thread sleeps during request processing anyway.
> - Allocate driver requests on the stack rather than using malloc().
>
> Differential Revision: https://reviews.freebsd.org/D1723
> Tested by: scottl
> MFC after: 2 weeks
I think we should further change this to only allow the watchdog to be used
with KCS and SMIC so that watchdog requests never sleep. I think that we
could then revert r272366 as to my knowledge this was the only watchdog driver
that could sleep?
--
John Baldwin
More information about the svn-src-all
mailing list