svn commit: r286760 - in head/lib/libc: . secure sys
Konstantin Belousov
kostikbel at gmail.com
Fri Aug 14 12:16:56 UTC 2015
On Fri, Aug 14, 2015 at 07:02:25AM -0500, Pedro Giffuni wrote:
> Hello;
>
> > Il giorno 14/ago/2015, alle ore 06:24, Konstantin Belousov <kostikbel at gmail.com> ha scritto:
> >
> > On Fri, Aug 14, 2015 at 03:03:14AM +0000, Pedro F. Giffuni wrote:
> >> +/*
> >> + * It'd be nice to have this automatically generated, but we don't
> >> + * know to what version they will eventually belong, so for now
> >> + * it has to be manual.
> >> + */
> > The comment does not make a bit of sense.
> > It also raises the question whether the author(s) of the change
> > ever understand what do they change.
> >
>
> It was blindly copy/pasted from the originating lib/libc/sys/Symbol.map.
In the sys/Symbol.map it referenced the generated symbols for the
syscall trampolines. You could clarify this in the comment, by limiting
its scope to the syscall symbols. But I do not object to removing it
from sys/Symbol.map.
>
> I will remove both stale comments.
Ok.
More information about the svn-src-all
mailing list