svn commit: r271735 - head/sys/net

[Kevin Lo]

On Thu, Sep 18, 2014 at 09:18:34AM +0400, Gleb Smirnoff wrote:
> 
> On Thu, Sep 18, 2014 at 03:09:35AM +0000, Marcelo Araujo wrote:
> M> Author: araujo (ports committer)
> M> Date: Thu Sep 18 03:09:34 2014
> M> New Revision: 271735
> M> URL: http://svnweb.freebsd.org/changeset/base/271735
> M> 
> M> Log:
> M>   Remove old comment, we already do 802.1q tagging.
> 
> But the comment speaks about 802.1p priority tagging, which
> we do not support. So the comment was absolutely correct.
> 
> I'd prefer to see patch reverted.

Sorry, I overlooked that.  Marcelo has a patch with 802.1p tagging support,
I thought the patch was committed.

> M>   Phabric:	D797
> M>   Reviewed by:	kevlo
> M>   Approved by:	kevlo
> M>   Sponsored by:	QNAP Systems Inc.
> M> 
> M> Modified:
> M>   head/sys/net/if_vlan.c
> M> 
> M> Modified: head/sys/net/if_vlan.c
> M> ==============================================================================
> M> --- head/sys/net/if_vlan.c	Thu Sep 18 03:02:00 2014	(r271734)
> M> +++ head/sys/net/if_vlan.c	Thu Sep 18 03:09:34 2014	(r271735)
> M> @@ -29,8 +29,7 @@
> M>  
> M>  /*
> M>   * if_vlan.c - pseudo-device driver for IEEE 802.1Q virtual LANs.
> M> - * Might be extended some day to also handle IEEE 802.1p priority
> M> - * tagging.  This is sort of sneaky in the implementation, since
> M> + * This is sort of sneaky in the implementation, since
> M>   * we need to pretend to be enough of an Ethernet implementation
> M>   * to make arp work.  The way we do this is by telling everyone
> M>   * that we are an Ethernet, and then catch the packets that
> M> 
> 
> -- 
> Totus tuus, Glebius.

	Kevin