svn commit: r274710 - head/sbin/ifconfig
Mark Felder
feld at FreeBSD.org
Wed Nov 19 13:57:40 UTC 2014
Author: feld (ports committer)
Date: Wed Nov 19 13:57:39 2014
New Revision: 274710
URL: https://svnweb.freebsd.org/changeset/base/274710
Log:
Expose groups by default in ifconfig output. This was never hidden by
OpenBSD; unsure why we chose to do so. As groups are a requirement for
pf, exposing them by default will make our pf implementation less
confusing.
While here add a missing free() that OpenBSD fixed 7 years ago.
PR: 194925
Differential Revision: https://reviews.freebsd.org/D1185
Approved by: des
Obtained from: OpenBSD
Modified:
head/sbin/ifconfig/ifgroup.c
Modified: head/sbin/ifconfig/ifgroup.c
==============================================================================
--- head/sbin/ifconfig/ifgroup.c Wed Nov 19 13:31:08 2014 (r274709)
+++ head/sbin/ifconfig/ifgroup.c Wed Nov 19 13:57:39 2014 (r274710)
@@ -86,9 +86,6 @@ getifgroups(int s)
struct ifgroupreq ifgr;
struct ifg_req *ifg;
- if (!verbose)
- return;
-
memset(&ifgr, 0, sizeof(ifgr));
strlcpy(ifgr.ifgr_name, name, IFNAMSIZ);
@@ -121,6 +118,8 @@ getifgroups(int s)
}
if (cnt)
printf("\n");
+
+ free(ifgr.ifgr_groups);
}
static void
More information about the svn-src-all
mailing list