svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread

[Alfred Perlstein]

This looks easy enough to fix under _thr_find_thread() in libthread.

Any interest in fixing it?

Might be worth hacking _thr_find_thread() to take an ERRNO to return 
based on NULL until we chase down all the paths into it just in case 
EINVAL is a valid ptr.

Also, just wondering what happens on other platforms, does it elicit a 
crash?  Ie. is NULL a safe value to pass in on other platforms?

-Alfred

On 11/15/14, 9:08 PM, Garrett Cooper wrote:
> Author: ngie
> Date: Sun Nov 16 05:08:19 2014
> New Revision: 274573
> URL: https://svnweb.freebsd.org/changeset/base/274573
>
> Log:
>    Expect :pthread_detach to fail with EINVAL instead of ESRCH on FreeBSD
>    
>    PR: 191906
>    In collaboration with: pho
>
> Modified:
>    head/contrib/netbsd-tests/lib/libpthread/t_detach.c
>
> Modified: head/contrib/netbsd-tests/lib/libpthread/t_detach.c
> ==============================================================================
> --- head/contrib/netbsd-tests/lib/libpthread/t_detach.c	Sun Nov 16 05:06:35 2014	(r274572)
> +++ head/contrib/netbsd-tests/lib/libpthread/t_detach.c	Sun Nov 16 05:08:19 2014	(r274573)
> @@ -75,6 +75,10 @@ ATF_TC_BODY(pthread_detach, tc)
>   	rv = pthread_join(t, NULL);
>   	ATF_REQUIRE(rv == EINVAL);
>   
> +#if defined(__FreeBSD__)
> +	atf_tc_expect_fail("PR # 191906: fails with EINVAL, not ESRCH");
> +#endif
> +
>   	/*
>   	 * As usual, ESRCH should follow if
>   	 * we try to detach an invalid thread.
>