svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus

[Ed Maste]

On 15 December 2014 at 16:04, Craig Rodrigues <rodrigc at freebsd.org> wrote:
>
>
> On Mon, Dec 15, 2014 at 6:25 AM, Ed Maste <emaste at freebsd.org> wrote:
>>
>>  cfns.h: cfns.gperf
>>         gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \
>> -           ${.ALLSRC} > ${.TARGET}
>> +           ${.ALLSRC} > ${.TARGET} || (rm -f ${.TARGET}; false)
>>
>
> Instead of removing the target you could have done something like:
>
>  cfns.h: cfns.gperf
>         gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \
>            ${.ALLSRC} > ${.TARGET}_temp
>            mv ${.TARGET}_temp ${.TARGET}

Yeah.  There are already examples of both approaches in the tree; I
don't see a reason to strongly prefer one over the other.