svn commit: r255130 - in head/sys: arm/conf arm/freescale/imx boot/fdt/dts

[Rui Paulo]

On 2 Sep 2013, at 01:26, Aleksandr Rybalko <ray at ddteam.net> wrote:

> Hello Rui!
> 
> On Sun, 1 Sep 2013 20:15:36 +0000 (UTC)
> Rui Paulo <rpaulo at FreeBSD.org> wrote:
> 
>> Author: rpaulo
>> Date: Sun Sep  1 20:15:35 2013
>> New Revision: 255130
>> URL: http://svnweb.freebsd.org/changeset/base/255130
>> 
>> Log:
>>  Initial support for the Digi ConnectCore(c) i.MX53 / Wi-i.MX53 boards.
>> 
>>  There are many drivers missing, but we can reach single user mode now.
>> 
>>  Hardware graciously donated by Douglas Beattie.
>> 
>> Added:
>>  head/sys/arm/conf/DIGI-CCWMX53   (contents, props changed)
>>  head/sys/arm/freescale/imx/files.imx53   (contents, props changed)
>>  head/sys/arm/freescale/imx/imx53_machdep.c   (contents, props changed)
>>  head/sys/arm/freescale/imx/std.imx53   (contents, props changed)
>>  head/sys/boot/fdt/dts/digi-ccwmx53.dts   (contents, props changed)
>>  head/sys/boot/fdt/dts/imx53x.dtsi   (contents, props changed)
>> Modified:
>>  head/sys/arm/freescale/imx/imx51_ccm.c
>>  head/sys/arm/freescale/imx/imx51_gpio.c
>>  head/sys/arm/freescale/imx/imx51_iomux.c
>>  head/sys/arm/freescale/imx/imx51_machdep.c
>>  head/sys/arm/freescale/imx/imx_gpt.c
>>  head/sys/arm/freescale/imx/imx_wdog.c
>> 
> 
> [[cut]]
> 
>> Modified: head/sys/arm/freescale/imx/imx51_machdep.c
>> ==============================================================================
>> --- head/sys/arm/freescale/imx/imx51_machdep.c	Sun Sep  1 19:59:54 2013	(r255129)
>> +++ head/sys/arm/freescale/imx/imx51_machdep.c	Sun Sep  1 20:15:35 2013	(r255130)
>> @@ -107,7 +107,7 @@ platform_devmap_init(void)
>> 	 * Map segment where UART1 and UART2 located.
>> 	 */
>> 	fdt_devmap[0].pd_va = IMX51_DEV_VIRT_BASE + 0x03f00000;
>> -	fdt_devmap[0].pd_pa = 0x73f00000;
>> +	fdt_devmap[0].pd_pa = 0x53f00000;
> 
> I hope it is just mistake, is it?

Yes, fixed.

> 
>> 	fdt_devmap[0].pd_size = 0x00100000;
>> 	fdt_devmap[0].pd_prot = VM_PROT_READ | VM_PROT_WRITE;
>> 	fdt_devmap[0].pd_cache = PTE_NOCACHE;
>> 
> 
> [[cut]]
> 
> And, do you board have own FDT blob?
> If it so, then better to try to use it. Otherwise, it is better to
> unify compatible property values, instead of do test for growing list.

The FDT blob is not relevant to this since console.c is not using any FDT functions. This is just a debugging aid for the platform bring up until I get uart_dev_imx.c working correctly.
That said, eventually this will go away. The i.MX51 port you did has the same problem, anyway.

--
Rui Paulo