svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts

[Allan Jude]

On 2013-10-15 12:58, Adam McDougall wrote:
> On Tue, Oct 15, 2013 at 04:28:21PM +0000, Teske, Devin wrote:
>
>   >>>> +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=1}
>   >>>> 
>   >>> > 
>   >>> > 
>   >>> I believe this trick is no longer needed after r254591.
>   >>> 
>   > 
>   > This may be the case, I am not sure if r254591 'always' fixes the problem, maybe someone else can weight in with a more definite yes/no
>   > 
>   
>   I'll hold off on doing anything with 4K sectors gnop hack until
>   we get confirmation.
>   
> r254591 says:
> "Use GEOM's stripesize attribute, if set, as the physical sector size of the GEOM."
>
> I'm pretty sure GEOM only knows for a subset of devices, for example if the 
> kernel contains a quirk based on the drive model.  If you are aiming for 
> performance, my 2 cents is to keep it.  On the other hand, forcing 4k and thus 
> ashift=12 wastes more space in a zpool on a 512b device so it would be nice to 
> make this a toggle in the GUI defaulting to on.  If it is already, I apologize, I 
> haven't tried the code in a few iterations.
>
>
Yes, the gnop 4k section option is a toggle, which defaults to on.

-- 
Allan Jude