svn commit: r257542 - head/sys/ofed/drivers/net/mlx4

Alfred Perlstein alfred at FreeBSD.org
Sat Nov 2 10:49:48 UTC 2013


Author: alfred
Date: Sat Nov  2 10:49:47 2013
New Revision: 257542
URL: http://svnweb.freebsd.org/changeset/base/257542

Log:
  Fix API mismatch exposed by lagg.
  
  When destroying a lagg the driver tries to restore the old mac and
  fails due to API mismatch

Modified:
  head/sys/ofed/drivers/net/mlx4/en_netdev.c

Modified: head/sys/ofed/drivers/net/mlx4/en_netdev.c
==============================================================================
--- head/sys/ofed/drivers/net/mlx4/en_netdev.c	Sat Nov  2 09:16:11 2013	(r257541)
+++ head/sys/ofed/drivers/net/mlx4/en_netdev.c	Sat Nov  2 10:49:47 2013	(r257542)
@@ -633,8 +633,8 @@ int mlx4_en_start_port(struct net_device
 	en_dbg(DRV, priv, "Setting mac for port %d\n", priv->port);
 	err = mlx4_register_mac(mdev->dev, priv->port,
 				mlx4_en_mac_to_u64(IF_LLADDR(dev)));
-	if (err) {
-		en_err(priv, "Failed setting port mac\n");
+	if (err < 0) {
+		en_err(priv, "Failed setting port mac err=%d\n", err);
 		goto tx_err;
 	}
 	mdev->mac_removed[priv->port] = 0;


More information about the svn-src-all mailing list