svn commit: r250430 - head/sbin/dmesg

[Alexey Dokuchaev]

On Fri, May 10, 2013 at 08:43:37AM -0400, Eitan Adler wrote:
> On 10 May 2013 03:42, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > On Fri, May 10, 2013 at 03:42:48AM +0000, Eitan Adler wrote:
> >> New Revision: 250430
> >> URL: http://svnweb.freebsd.org/changeset/base/250430
> >>
> >>       (void) setlocale(LC_CTYPE, "");
> >
> > It's a bit weird that you've left the cast here...
> 
> I didn't modify this line

OK.

> >> -     (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n");
> >> +     fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n");
> >
> > but removed it here for no particular reason.
> 
> Notice the additional 'c' in usage().

Of course.  But my question was about dropping the cast, not adding new
option.  Adding a new option should have resulted in the following diff:

-     (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n");
+     (void)fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n");

./danfe