svn commit: r253662 - in head: lib/libc/gen sys/vm tools/tools/sysdoc

[Bruce Evans]

On Sat, 27 Jul 2013, Andrey Zonov wrote:

> On 7/27/13 12:47 AM, Bruce Evans wrote:
>> ...
>> Especially since the main reason numbered sysctls exist is to support old
>> binaries (and sources) that use them.
>
> Does it look OK?

It looks functionally OK, but ugly.

> diff --git a/sys/vm/vm_param.h b/sys/vm/vm_param.h
> index 44306be..0323473 100644
> --- a/sys/vm/vm_param.h
> +++ b/sys/vm/vm_param.h
> @@ -82,8 +82,9 @@
> #define        VM_V_CACHE_MIN          7       /* cnt.v_cache_min */
> #define        VM_V_CACHE_MAX          8       /* cnt.v_cache_max */
> #define VM_V_PAGEOUT_FREE_MIN  9       /* cnt.v_pageout_free_min */
> -#define VM_SWAPPING_ENABLED    10      /* swapping enabled */
> -#define        VM_MAXID                11      /* number of valid vm ids */
> +/*#define      VM_PAGEOUT_ALGORITHM    10      pageout algorithm */

Commenting out things like this is ugly.  Code should be commented out using
#if 0, but here I think I prefere changing the #defined name to something
like VM_OBS_10.  VM_OBS_PAGEOUT_ALGORITGHM would be too long.

> +#define VM_SWAPPING_ENABLED    11      /* swapping enabled */
> +#define        VM_MAXID                12      /* number of valid vm ids */
>
> #define CTL_VM_NAMES { \
>        { 0, 0 }, \
> @@ -96,6 +97,7 @@
>        { "v_cache_min", CTLTYPE_UINT }, \
>        { "v_cache_max", CTLTYPE_UINT }, \
>        { "v_pageout_free_min", CTLTYPE_UINT}, \
> +       { "obsolete_pageout_algorithm", CTLTYPE_INT}, \
>        { "swap_enabled", CTLTYPE_INT},\
> }

Bruce