svn commit: r259896 - head/sys/dev/cxgb/common

[Dimitry Andric]

On 26 Dec 2013, at 02:51, Adrian Chadd <adrian at freebsd.org> wrote:
> I'd prefer you didn't remove unused code in drivers like this. If you
> must, #if 0 them out.

I don't mind either way, but some other people are very much opposed to
littering code with #if 0'd sections.  So, how do to determine what is
right in each situation? :-)


> Future people hacking on the driver may find it nice to have as much
> code in there which talks to the hardware. It may not be currently
> called, but it's at least there.

In this particular case, the code has never been used, even when the
file was originally committed, so I would say the chances of it ever
being used again are near zero.  (And even after deletion, the old
versions are available in our repository.)

For more "active" drivers, I will certainly just use #if, or simply turn
off the -Wunused-function warning.  And hope the code gets used
eventually. :-)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20131226/d854c0e1/attachment.sig>