svn commit: r259668 - head/sys/cddl/dev/fbt

[Justin Hibbits]

On Sat, 21 Dec 2013 08:31:01 +0800
Howard Su <howard0su at gmail.com> wrote:

> On Saturday, December 21, 2013, Justin Hibbits wrote:
> 
> > Author: jhibbits
> > Date: Fri Dec 20 23:18:14 2013
> > New Revision: 259668
> > URL: http://svnweb.freebsd.org/changeset/base/259668
> >
> > Log:
> >   Fix a couple bugs in FBT PowerPC.  Clamp the size to a
> > 'instruction size' not
> >   'byte size', and fix a typo.
> >
> >   MFC after:    2 weeks
> >
> > Modified:
> >   head/sys/cddl/dev/fbt/fbt_powerpc.c
> >
> > Modified: head/sys/cddl/dev/fbt/fbt_powerpc.c
> >
> > ==============================================================================
> > --- head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 21:31:50 2013
> >  (r259667)
> > +++ head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 23:18:14 2013
> >  (r259668)
> > @@ -219,7 +219,7 @@ fbt_provide_module_function(linker_file_
> >                 return (0);
> >
> >         instr = (u_int32_t *) symval->value;
> > -       limit = (u_int32_t *) (symval->value + symval->size);
> > +       limit = (u_int32_t *) (symval->value + symval->size /
> > sizeof(u_int32_t));
> >
> > This change doesn't look right to me. symval->value is caddr_t
> > (char*).
> why add instruction size to it?

D'oh, complete brain-o.  I had read it as a size field, not a
pointer field.  Fixed now.

- Justin