svn commit: r241410 - head/sys/cam/scsi

[Alexander Motin]

Author: mav
Date: Wed Oct 10 19:32:40 2012
New Revision: 241410
URL: http://svn.freebsd.org/changeset/base/241410

Log:
  There are SCSI conditions that are not an errors. In those cases cderror()
  returns zero while request status is not CAM_REQ_CMP.  That could cause
  partial device attach or other unexpected results.
  
  Found by:	Clang Static Analyzer

Modified:
  head/sys/cam/scsi/scsi_cd.c

Modified: head/sys/cam/scsi/scsi_cd.c
==============================================================================
--- head/sys/cam/scsi/scsi_cd.c	Wed Oct 10 19:27:40 2012	(r241409)
+++ head/sys/cam/scsi/scsi_cd.c	Wed Oct 10 19:32:40 2012	(r241410)
@@ -1741,6 +1741,7 @@ cddone(struct cam_periph *periph, union 
 					       * bytes.
 					       */
 		struct	   cd_params *cdp;
+		int error;
 
 		cdp = &softc->params;
 
@@ -1749,28 +1750,26 @@ cddone(struct cam_periph *periph, union 
 		cdp->disksize = scsi_4btoul (rdcap->addr) + 1;
 		cdp->blksize = scsi_4btoul (rdcap->length);
 
-		if ((csio->ccb_h.status & CAM_STATUS_MASK) == CAM_REQ_CMP) {
+		/*
+		 * Retry any UNIT ATTENTION type errors.  They
+		 * are expected at boot.
+		 */
+		if ((csio->ccb_h.status & CAM_STATUS_MASK) == CAM_REQ_CMP ||
+		    (error = cderror(done_ccb, CAM_RETRY_SELTO,
+				SF_RETRY_UA | SF_NO_PRINT)) == 0) {
 
 			snprintf(announce_buf, sizeof(announce_buf),
 				"cd present [%lu x %lu byte records]",
 				cdp->disksize, (u_long)cdp->blksize);
 
 		} else {
-			int	error;
-			/*
-			 * Retry any UNIT ATTENTION type errors.  They
-			 * are expected at boot.
-			 */
-			error = cderror(done_ccb, CAM_RETRY_SELTO,
-					SF_RETRY_UA | SF_NO_PRINT);
 			if (error == ERESTART) {
 				/*
 				 * A retry was scheuled, so
 				 * just return.
 				 */
 				return;
-			} else if (error != 0) {
-
+			} else {
 				int asc, ascq;
 				int sense_key, error_code;
 				int have_sense;