svn commit: r242620 - head/bin/sh

[Pawel Jakub Dawidek]

On Mon, Nov 05, 2012 at 05:52:18PM +0000, Jilles Tjoelker wrote:
> Author: jilles
> Date: Mon Nov  5 17:52:18 2012
> New Revision: 242620
> URL: http://svnweb.freebsd.org/changeset/base/242620
> 
> Log:
>   sh: Change cmdtype in tblentry from short to signed char.
>   
>   If this is a smaller type than int anyway, we can make it the smallest
>   possible.
> 
> Modified:
>   head/bin/sh/exec.c
> 
> Modified: head/bin/sh/exec.c
> ==============================================================================
> --- head/bin/sh/exec.c	Mon Nov  5 17:50:40 2012	(r242619)
> +++ head/bin/sh/exec.c	Mon Nov  5 17:52:18 2012	(r242620)
> @@ -85,7 +85,7 @@ struct tblentry {
>  	struct tblentry *next;	/* next entry in hash chain */
>  	union param param;	/* definition of builtin function */
>  	int special;		/* flag for special builtin commands */
> -	short cmdtype;		/* index identifying command */
> +	signed char cmdtype;	/* index identifying command */

Why not simply 'char'?

>  	char rehash;		/* if set, cd done since entry created */
>  	char cmdname[];		/* name of command */
>  };

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20121105/a5c10f04/attachment.sig>