svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

[Eitan Adler]

On Mon, Mar 19, 2012 at 8:35 AM, John Baldwin <jhb at freebsd.org> wrote:
> On Sunday, March 18, 2012 8:41:40 pm Eitan Adler wrote:
>> Author: eadler
>> Date: Mon Mar 19 00:41:40 2012
>> New Revision: 233136
>> URL: http://svn.freebsd.org/changeset/base/233136
>>
>> Log:
>>   X11BASE is not used any more and has been killed by the x11 team.
>>
>>   Reviewed by:        ???
>>   Approved by:        ???
>>   MFC after:  3 days
>>
>> Modified:
>>   head/secure/usr.bin/ssh/Makefile
>>   head/secure/usr.sbin/sshd/Makefile
>
> This looks wrong.  While X11BASE is certainly dead, LOCALBASE is not, so the
> existing code should have been changed, but not removed.  Something like this:
>
> .if defined(LOCALBASE)
> CFLAGS+= -DXAUTH_PATH=\"${LOCALBASE}/bin/xauth\"
> .endif

I think I missed "X11BASE?=${LOCALBASE}"  in the original code making
me believe this change was a no-op. I'll have a patch to fix this
soon.



-- 
Eitan Adler
Source & Ports committer
X11, Bugbusting teams