svn commit: r236377 - head/sys/dev/vxge/vxgehal

[Eitan Adler]

On 1 June 2012 07:24, John Baldwin <jhb at freebsd.org> wrote:
> This is why I personally loathe assignment side effects in boolean expressions
> for control flow.  I tend to write this sort of thing instead as:
>
>        channel->dtr_arr[dtr_index].dtr = dtrh;
>        if (dtrh != NULL) {

Same here. I was told to use the assignment is style(9) by multiple
people though. If it really is, I wish it would change.

-- 
Eitan Adler
Source & Ports committer
X11, Bugbusting teams