svn commit: r230125 - head/sys/kern

[Colin Percival]

On 01/15/12 15:28, John Baldwin wrote:
> On 1/15/12 2:09 AM, Eitan Adler wrote:
>> Log:
>>    - Fix undefined behavior when device_get_name is null
>>    - Make error message more informative
> 
> The in-kernel printf(9) always prints "(null)" for %s when the pointer is NULL,
> so that wasn't undefined behavior.  Printing out the driver name is a useful
> change, but the "(unknown)" bits are just noise as it isn't clear that
> "(unknown)" is substantially better than "(null)".

I think the change from "(null)" to "(unknown)" is useful, since when I see
"(null)" printed my immediate thought is "looks like there's a bug I need to
track down here".

-- 
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid