svn commit: r230984 - head/sys/kern

Ryan Stone rstone at FreeBSD.org
Sat Feb 4 16:49:30 UTC 2012


Author: rstone
Date: Sat Feb  4 16:49:29 2012
New Revision: 230984
URL: http://svn.freebsd.org/changeset/base/230984

Log:
  Whenever a new kernel thread is spawned, explicitly clear any CPU affinity
  set on the new thread.  This prevents the thread from inadvertently
  inheriting affinity from a random sibling.
  
  Submitted by:	attilio
  Tested by:	pho
  MFC after:	1 week

Modified:
  head/sys/kern/kern_kthread.c

Modified: head/sys/kern/kern_kthread.c
==============================================================================
--- head/sys/kern/kern_kthread.c	Sat Feb  4 15:43:16 2012	(r230983)
+++ head/sys/kern/kern_kthread.c	Sat Feb  4 16:49:29 2012	(r230984)
@@ -29,6 +29,7 @@ __FBSDID("$FreeBSD$");
 
 #include <sys/param.h>
 #include <sys/systm.h>
+#include <sys/cpuset.h>
 #include <sys/kthread.h>
 #include <sys/lock.h>
 #include <sys/mutex.h>
@@ -117,6 +118,9 @@ kproc_create(void (*func)(void *), void 
 
 	/* call the processes' main()... */
 	cpu_set_fork_handler(td, func, arg);
+
+	/* Avoid inheriting affinity from a random parent. */
+	cpuset_setthread(td->td_tid, cpuset_root);
 	thread_lock(td);
 	TD_SET_CAN_RUN(td);
 	sched_prio(td, PVM);
@@ -299,6 +303,9 @@ kthread_add(void (*func)(void *), void *
 
 	tidhash_add(newtd);
 
+	/* Avoid inheriting affinity from a random parent. */
+	cpuset_setthread(newtd->td_tid, cpuset_root);
+
 	/* Delay putting it on the run queue until now. */
 	if (!(flags & RFSTOPPED)) {
 		thread_lock(newtd);


More information about the svn-src-all mailing list